Jump to content


Photo

Refactoring of the NI 3 button dialog


  • Please log in to reply
3 replies to this topic

#1 Michael Aivaliotis

Michael Aivaliotis
  • JKI Team
  • 501 posts
  • Gender:Male

Posted 13 October 2008 - 05:28 AM

In this example, we show how you can refactor existing code. We have taken the 3 button dialog that ships with the base version of LabVIEW and upgraded it to use the JKI State Machine template. We have not added or changed any functionality. Also, we have not changed the way the functionality is implemented.

Here is a screenshot showing how the VI looked before the refactoring:

3buttonbefore.png

Here is a screenshot showing how the VI looked after applying the JKI State Machine template:

3buttonafter.png

We've attached the the refactored VI that has been written in LabVIEW 8.2. Remember that you need to have the JKI State Machine package installed in your version of LabVIEW. Click here for information on how to install the JKI State Machine.

Posted Image

Attached File  Three_Button_Dialog_CORE___JKI.vi   202.79KB   4064 downloads
The original VI is located at: <vi.lib>\Utility\error.llb\Three Button Dialog CORE.vi

Click here to watch a video that describes some of the design thought process used in the re-factoring:
Video: Refactoring the LabVIEW three button dialog
  • 0
Michael Aivaliotis - VIPM Product Manager

VIPM Idea Exchange <<-- Post your VIPM Feature Requests Here
VIPM Online Documentation
JKI Product Support <<-- For urgent requests, submit a ticket

#2 Michael Aivaliotis

Michael Aivaliotis
  • JKI Team
  • 501 posts
  • Gender:Male

Posted 14 October 2008 - 09:55 PM

We just found a small bug in the release of this example. Thanks goes out to Darren Nattinger of National Instruments for pointing it out ;) . If you've downloaded it before Oct.14,2008 (3pm) then please re-download it. The original link has been updated.
  • 0
Michael Aivaliotis - VIPM Product Manager

VIPM Idea Exchange <<-- Post your VIPM Feature Requests Here
VIPM Online Documentation
JKI Product Support <<-- For urgent requests, submit a ticket

#3 wevanarsdale

wevanarsdale
  • Members
  • 1 posts

Posted 27 October 2008 - 03:56 PM

In this example, we show how you can refactor existing code. We have taken the 3 button dialog that ships with the base version of LabVIEW and upgraded it to use the JKI State Machine template. We have not added or changed any functionality. Also, we have not changed the way the functionality is implemented...


Nice example... However, it is somewhat ironic that NI's Three Button Dialog CORE.vi appears in the hierarchy of your Three_Button_Dialog_CORE___JKI.vi.
Bill VanArsdale
  • 0

#4 Michael Aivaliotis

Michael Aivaliotis
  • JKI Team
  • 501 posts
  • Gender:Male

Posted 28 October 2008 - 06:44 PM

Nice example... However, it is somewhat ironic that NI's Three Button Dialog CORE.vi appears in the hierarchy of your Three_Button_Dialog_CORE___JKI.vi.
Bill VanArsdale

Well yes, the reason of course is NI uses it in the General Error Handler.vi which we call in the Error Handler frame of our state machine.
  • 0
Michael Aivaliotis - VIPM Product Manager

VIPM Idea Exchange <<-- Post your VIPM Feature Requests Here
VIPM Online Documentation
JKI Product Support <<-- For urgent requests, submit a ticket